Skip to content

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Apr 3, 2024

I often want to download CI artifacts published from our workflows (I suspect others might do the same), but it's a bit annoying to extract their links from the CI logs currently. This PR also outputs URLs to them to the GitHub Actions summaries.

r? @Mark-Simulacrum

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Apr 3, 2024
@Kobzol
Copy link
Member Author

Kobzol commented Apr 3, 2024

@bors try

Let's see if it works.

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2024
Output URLs of CI artifacts to GitHub summary

I often want to download CI artifacts published from our workflows (I suspect others might do the same), but it's a bit annoying to extract their links from the CI logs currently. This PR also outputs URLs to them to the GitHub Actions summaries.

r? `@Mark-Simulacrum`
@bors
Copy link
Collaborator

bors commented Apr 3, 2024

⌛ Trying commit 508530d with merge 04a84e5...

@Mark-Simulacrum
Copy link
Member

r=me

@bors
Copy link
Collaborator

bors commented Apr 3, 2024

☀️ Try build successful - checks-actions
Build commit: 04a84e5 (04a84e54c358cd7a7d18e2e6f0a2366f8bd59450)

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 3, 2024

☀️ Try build successful - checks-actions
Build commit: 04a84e5 (04a84e54c358cd7a7d18e2e6f0a2366f8bd59450)

@Kobzol
Copy link
Member Author

Kobzol commented Apr 3, 2024

image

Looks pretty good! 🎉

https://github.com/rust-lang-ci/rust/actions/runs/8539681701

@Kobzol
Copy link
Member Author

Kobzol commented Apr 3, 2024

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Apr 3, 2024

📌 Commit 508530d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 3, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#123209 (Add section to sanitizer doc for `-Zexternal-clangrt`)
 - rust-lang#123342 (x.py test: remove no-op --skip flag)
 - rust-lang#123382 (Assert `FnDef` kind)
 - rust-lang#123386 (Set `CARGO` instead of `PATH` for Rust Clippy)
 - rust-lang#123393 (rustc_ast: Update `P<T>` docs to reflect mutable status.)
 - rust-lang#123394 (Postfix match fixes)
 - rust-lang#123412 (Output URLs of CI artifacts to GitHub summary)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 658c8f7 into rust-lang:master Apr 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 3, 2024
Rollup merge of rust-lang#123412 - Kobzol:ci-artifacts-in-summary, r=Mark-Simulacrum

Output URLs of CI artifacts to GitHub summary

I often want to download CI artifacts published from our workflows (I suspect others might do the same), but it's a bit annoying to extract their links from the CI logs currently. This PR also outputs URLs to them to the GitHub Actions summaries.

r? `@Mark-Simulacrum`
@rustbot rustbot added this to the 1.79.0 milestone Apr 3, 2024
@Kobzol Kobzol deleted the ci-artifacts-in-summary branch April 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants