Skip to content

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jul 29, 2025

Fixes #20320.

We should have better snippet handling. I started working on that but got distracted by other things.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2025
@Veykril Veykril added this pull request to the merge queue Jul 29, 2025
Merged via the queue into rust-lang:master with commit 06dc358 Jul 29, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2025
@ChayimFriedman2 ChayimFriedman2 deleted the mut-trait-impl-snippet branch July 29, 2025 10:43
@DropDemBits
Copy link
Contributor

cc #17332 (generate_constant is now the only misbehaving assist).


We should have better snippet handling.
@ChayimFriedman2 curious about your thoughts, since I was the one who did the initial push away from representing snippets in-text.

@ChayimFriedman2
Copy link
Contributor Author

@ChayimFriedman2 curious about your thoughts, since I was the one who did the initial push away from representing snippets in-text.

Yes, but a lot of assists still do it by text, we should switch everything to not use that (even assists which do not use the node editor, which is currently impossible for them), then escape snippet bits in the generated text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Action generate mut trait is not a snippet
4 participants