Skip to content

feat: Edition aware parser #17620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 19, 2024
Merged

feat: Edition aware parser #17620

merged 7 commits into from
Jul 19, 2024

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Jul 17, 2024 •
edited
Loading

Fixes #16324 by allowing us to properly thread through the edition to the parser

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2024
@Veykril Veykril force-pushed the edition-aware-parser branch from 0221adb to 10cf817 Compare July 17, 2024 16:39
@Veykril Veykril changed the title Encode edition within FileId in the hir layer Edition aware parser Jul 18, 2024
@Veykril Veykril force-pushed the edition-aware-parser branch from 10cf817 to 5264f86 Compare July 18, 2024 06:54
@Veykril Veykril changed the title Edition aware parser Encode edition within FileId in the hir layer Jul 18, 2024
@Veykril Veykril marked this pull request as ready for review July 18, 2024 07:39
@Veykril Veykril changed the title Encode edition within FileId in the hir layer Edition aware parser Jul 18, 2024
@Veykril Veykril marked this pull request as draft July 18, 2024 08:27
@Veykril Veykril force-pushed the edition-aware-parser branch from 34d01b0 to 8523336 Compare July 19, 2024 13:26
@Veykril Veykril mentioned this pull request Jul 19, 2024
Closed
14 tasks
@Veykril Veykril force-pushed the edition-aware-parser branch from 8523336 to d235d09 Compare July 19, 2024 13:43
@Veykril Veykril marked this pull request as ready for review July 19, 2024 14:13
@Veykril
Copy link
Member Author

Veykril commented Jul 19, 2024 •
edited
Loading

There is a few things still missing, like handling dyn as a contextual keyword in 2015 edition and probably some other smaller things, but the important part here is being able to parse gen without everything suddenly breaking :) It also makes decl macros properly edition aware wrt to parsing now

@Veykril Veykril force-pushed the edition-aware-parser branch from d6b4237 to 546eb6b Compare July 19, 2024 14:44
@Veykril
Copy link
Member Author

Veykril commented Jul 19, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jul 19, 2024

📌 Commit 546eb6b has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 19, 2024

⌛ Testing commit 546eb6b with merge fa3dd33...

@bors
Copy link
Contributor

bors commented Jul 19, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing fa3dd33 to master...

@bors bors merged commit fa3dd33 into rust-lang:master Jul 19, 2024
This was referenced Jul 19, 2024
Merged
Merged
Merged
@Veykril Veykril deleted the edition-aware-parser branch July 19, 2024 15:33
@Veykril
Copy link
Member Author

Veykril commented Jul 19, 2024

Well that didn't quite work ...
image

@lnicola lnicola changed the title Edition aware parser feat: Edition aware parser Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edition dependent parser
3 participants
@Veykril @bors @rustbot