Un-bloat get_inner functions to restore lookup performance #639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup performance got slightly degraded when an is-empty check was added to HashMap
get_inner
. See #636.This restore original perfs by removing the intermediate function (based on a good suggestion by @cuviper).
Benchmark results before:
After:
Note: removing the is-empty check altogether is still worth considering, but this is the next best thing.