Skip to content

add comment why tvOS CI job is separate from the matrix #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

add comment why tvOS CI job is separate from the matrix #928

merged 1 commit into from
Jan 29, 2024

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 29, 2024

I wasted some time trying to figure out how to get this to work in the matrix until I saw that it is intentionally separate.

NobodyXu
NobodyXu approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu merged commit 9a15f3c into rust-lang:main Jan 29, 2024
@Be-ing Be-ing deleted the tvos_comment branch January 29, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcc thomcc thomcc approved these changes

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Be-ing @thomcc @NobodyXu