Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 29, 2025

🤖 New release

  • cc: 1.2.34 -> 1.2.35 (✓ API compatible changes)
Changelog


This PR was generated with release-plz.

@github-actions github-actions bot force-pushed the release-plz-2025-08-29T03-16-06Z branch 2 times, most recently from f1d41dc to ec629fa Compare August 29, 2025 16:43
@github-actions github-actions bot changed the title chore: release chore(cc): release v2.0.0 Aug 30, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-08-29T03-16-06Z branch from ec629fa to 71bfea7 Compare August 30, 2025 05:51
Copy link
Collaborator

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: release-plz thinks this is a breaking change

@NobodyXu
Copy link
Collaborator

NobodyXu commented Aug 31, 2025

Note: release-plz thinks this is a breaking change

It's due to obi1kenobi/cargo-semver-checks#638, since it doesn't have access to json docs of dependencies, any attempt to refactor will always end up being false positive.

I can fix it by manually wrapping the cc::windows_registry::find and re-enable semver-checks, that's a bit of extra work but would guarantee it would pass cc @madsmtm

@github-actions github-actions bot force-pushed the release-plz-2025-08-29T03-16-06Z branch from 71bfea7 to 7dfd8eb Compare August 31, 2025 13:40
@madsmtm
Copy link
Collaborator

madsmtm commented Aug 31, 2025

Either that, or somehow tell release-plz that it's a different version?

@madsmtm
Copy link
Collaborator

madsmtm commented Aug 31, 2025

Then again, maybe it's fine to wrap the find function as well.

@github-actions github-actions bot changed the title chore(cc): release v2.0.0 chore(cc): release v1.2.35 Sep 1, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-08-29T03-16-06Z branch from 7dfd8eb to 5555160 Compare September 1, 2025 09:47
@NobodyXu NobodyXu closed this Sep 1, 2025
@NobodyXu NobodyXu reopened this Sep 1, 2025
@NobodyXu
Copy link
Collaborator

NobodyXu commented Sep 1, 2025

fixed in #1539 now semver-checks is all good

@NobodyXu NobodyXu enabled auto-merge (squash) September 1, 2025 09:58
@NobodyXu NobodyXu requested a review from madsmtm September 1, 2025 10:14
@NobodyXu
Copy link
Collaborator

NobodyXu commented Sep 1, 2025

cc @madsmtm

@NobodyXu NobodyXu merged commit 9b4389c into main Sep 1, 2025
154 checks passed
@NobodyXu NobodyXu deleted the release-plz-2025-08-29T03-16-06Z branch September 1, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants