io-adapters: forward seek_relative in std adapters and require Rust 1.81
#702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conaclos
force-pushed
the
seek-relative-std-adapter
branch
2 times, most recently
from
4ebda04 to
050e882
Compare
Conaclos
commented
Sep 10, 2025
| format!("{e:?}"), | ||
| )), | ||
| Err(e @ embedded_io::WriteFmtError::FmtError) => { | ||
| Err(std::io::Error::other(format!("{e:?}"))) |
There was a problem hiding this comment.
This fixes a Clippy error
Dirbaio
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embedded-ioMSRV is set to 1.81, whileembedded-io-adaptersMSRV was set to 1.60.Since
embedded-io-adaptersdepends onembedded-ioit makes sense of requiring the same minimum Rust version (1.81).This allows us to forward calls of
seek_relativein the std adapters.seek_relativeis stable since Rust 1.80.