This repository was archived by the owner on Jul 31, 2023. It is now read-only.
Fix automatic Rake task detection. #456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the globPattern used in rake.ts was failing to find Rakefiles if they were named 'Rakefile', without the .rb extension. This fixes the globPattern so now it matches in that case. This has the downside of also matching any filename that starts with Rakefile, e.g. 'Rakefile2' or 'Rakefileadsadadsad', but I'm not sure of a great way to fix this without that downside.
|
@wingrunr21 sorry for the ping, can this fix be merged? :) |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the globPattern used in rake.ts was failing to find Rakefiles if they were named
Rakefile, without the.rb` extension. This fixes the globPattern so now it matches in that case.This has the downside of also matching any filename that starts with
Rakefile, e.g.Rakefile2orRakefileadsadadsad, but I'm not sure of a great way to fix this without that downside.If you select
Task: Run Taskin the Command Palette you can see the difference (note the workspace needs to have a file namedRakefile,Rakefile.rbwill be detected without this change).Before:
After:
This fixes #273.