Skip to content

Conversation

BZngr
Copy link
Contributor

@BZngr BZngr commented Nov 8, 2022

This PR fixes a CodeBuilder latent bug regarding the creation of Property Let/Set code block(s) based on a Property Let/Set prototype.

MCVE:

'Use as a prototype for CodeBuilder to generate a Property Set member
Public Property Let Test(ByVal RHS Variant)
End Property

yields a Property Set with a duplicated Value parameter:

Public Property Set Test(ByVal RHS Variant, ByVal RHS Variant)
	Err.Raise 5					'TODO: Implement member
End Property

BZngr added 2 commits November 8, 2022 12:52
Adds MCVE tests for parameter list bug.  Scenarios: 'Property Let' prototype used to create a 'Property Set' member and 'Property Set' prototype used to create a 'Property Let' member.
Fixes parameter list bug for scenarios where: 'Property Let' prototype is used to create a 'Property Set' member or a 'Property Set' prototype is used to create a 'Property Let' member.
@rubberduck-vba-releasebot
Copy link
Member

@retailcoder retailcoder merged commit f4b04c3 into rubberduck-vba:next Nov 16, 2022
@BZngr BZngr deleted the SetFromLetCodeBuilder branch November 17, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants