Skip to content

Conversation

ambaradan
Copy link
Contributor

Author checklist (to be completed by original Author)

  • [ x] Is this document a good fit for the Rocky project ?
  • [ x] Is this a non-English contribution?
  • Title and Author MetaTags have been inserted into the document
  • If applicable, steps and instructions have been tested to work on a real system
  • [ x] Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (to be completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

@ambaradan
Copy link
Contributor Author

ambaradan commented Nov 10, 2021

Hello, I don't know if I did it right! I created a pull request and this included all the commits made on my repository. Is this the right way? Or I have to make a pull request per file, then one for each modified file.
I still struggle with git!!
The unverified commits were made directly from the Code Editor!

@sspencerwire
Copy link
Contributor

Hello, I don't know if I did it right! I created a pull request and this included all the commits made on my repository. Is this the right way? Or I have to make a pull request per file, then one for each modified file. I still struggle with git!! The unverified commits were made directly from the Code Editor!

Good day @ambaradan and thank you so much for your contributions so far!! My personal preference as an editor is to have one document per PR. The reason for this is that if something needs to be corrected in a document that was pushed as part of a PR, this will hold up the entire PR. Don't worry about that this time, however, as I'll work through this PR. It's going to take me a little time, but it should be up and merged (hopefully) later today. You aren't alone struggling with git. It's a learning curve to be sure!! :-) Thanks again! Steve

@sspencerwire sspencerwire changed the base branch from main to edit_351 November 10, 2021 14:21
@sspencerwire sspencerwire merged commit 2e7b52e into rocky-linux:edit_351 Nov 10, 2021
@sspencerwire
Copy link
Contributor

@ambaradan In markdown, when you want to force a new line but don't want a blank line in between, add two spaces (or more) at the end of the line. That will fix the formatting you were trying to fix in 03-commands.it.md.

@sspencerwire
Copy link
Contributor

@ambaradan Can I have a first and last name for the contributors: meta by chance? You can use an alias if you prefer. If not, I can simply but in your GitHub handle. Working through the PR now. Thanks

@sspencerwire
Copy link
Contributor

@ambaradan Here's a tip for you on admonitions: Line the portion of the text that should be within the admonition in line with the label for the admonition. For example, you should have this:

!!! Nota
    Questo comando è molto potente ed è altamente raccomandata la consultazione del manuale. Ha molti utilizzi derivati.

instead of this:

!!! Nota
Questo comando è molto potente ed è altamente raccomandata la consultazione del manuale. Ha molti utilizzi derivati.

I'm just throwing things in here that will hopefully help you when contributing in the future. Don't look at them as criticisms! ;-)
To be fair, I should have caught some of these on your first push of this document the other day (03-commands.it.md), but some apply to the other documents you've put in the PR as well.

@ambaradan
Copy link
Contributor Author

ambaradan commented Nov 10, 2021 via email

@ambaradan
Copy link
Contributor Author

ambaradan commented Nov 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants