-
Notifications
You must be signed in to change notification settings - Fork 347
Dev putta #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev putta #344
Conversation
Greetings again @theputta and thank you! Changing the admonitions to emojis is really up to the original author. Also, this has never been done before on our site, so it would have to be tested to see if it is even possible to do. (depends on whether it is supported in Mkdocs or not). I will pull this down and take a look and then check with the original author to see if he wants to change the admonitions to emojis. I don't see any problems with the command changes. I won't get to this right away, but may be able to take a look later today or tomorrow morning. Thanks again for your work!! Steve |
Thanks for the feedback about emojis. If accepted, I see that there are many changes to be done to other files also. Looking forward to making those changes, if that's the route we are going on. Shall I send a new PR with just command changes to make your life a bit easy ? |
That's not necessary unless you want to. :-) I can undo the emoji changes if needed. It will also give me a chance to "see" the emojis as I'm running a copy of Mkdocs locally that emulates the website. Thanks again for your contributions!! Steve |
@alemorvan Do you want to take a look at this and see what you think about the changes? I don't think the emojis will work with mkdocs currently, so that's probably out, but take a look at the PR at your convenience and just review the suggested changes. Thanks, Steve |
@theputta Good day Aditya! The use of emojis works. However, the highlighting provided by the original admonitions (red for warning, blue for note, etc.) in this case is important to what the author wanted. The good news for you, however, is that the emojis do work, so if you have a document that you would like to submit yourself, you can certainly use these. |
Hello @theputta. Thank you very much for this contribution. I'm adding my 👍 thumb as far as adding options is concerned, it's perfect. Regarding the replacement of admonitions by emojis, I confess I don't see the point. If you want to contribute on other documents, I suggest you for example to review the chapter on the network, which requires, in my opinion, a lot of complements (since the switch to systemd). Thanks again! |
Author checklist (to be completed by original Author)
Rocky Documentation checklist (to be completed by Rocky team)