-
Notifications
You must be signed in to change notification settings - Fork 347
Edit 335 - Italian translations #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
more coming...
Italian translation of Rocky Linux Documentation
* no problems with the translations, BUT, they were put into the wrong directories so had to be moved to the correct location. * each document had a cursory check with Google Translate to make sure that hte content of each was fundamentally the same as the original * removed the README.it.md translation as we can't really do this as yet because the original is a symbolic link. * A new PR for the mkdocs.yml file will need to be merged prior to these changes
Good day @ambaradan I've worked through the translations and they all look good. The README.it.md file was removed based on my comments yesterday. A couple of additional suggestions for you for future PR's:
I'm holding the merge of this PR as we need to enable the Italian language in our MkDocs implementation. That should be completed later today and then I'll merge this. Thanks again for your contributions!! |
Sorry, it was my intention to put the files in the correct destination, but the guide said to place them in "main". I misunderstood! I agree that placing them correctly avoids the risk of errors. Thank you
Sent with [ProtonMail](https://protonmail.com/) Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
Il lunedì 1 novembre 2021 16:29, sspencerwire ***@***.***> ha scritto:
… Good day ***@***.***(https://github.com/ambaradan) I've worked through the translations and they all look good. The README.it.md file was removed based on my comments yesterday. A couple of additional suggestions for you for future PR's:
- try to keep the document translation in the same folder as the original. For instance, most of your translation files should have been in docs/books/admin_guide/ ... the editor can move them, as I've done, but it is much less error-prone to have them in the correct spot to begin with. This is why you had to create books_index.it.md too, as that file needed to be index.it.md, but in the /docs/books/ folder.
I'm holding the merge of this PR as we need to enable the Italian language in our MkDocs implementation. That should be completed later today and then I'll merge this.
Thanks again for your contributions!!
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#339 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AU6LQRI62UMBODNRMFRWUFLUJ2W5PANCNFSM5HEI7WDQ).
Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).
|
@ambaradan So sorry to keep you waiting for this merge, but the language was officially added today, so I'm merging this now. Thanks again for your contribution! I'm looking forward to seeing more work from you in the future. ;-) Thanks, Steve |
No problem for the delay, the important thing is that they are useful to someone. Regarding further translations are already in the work.... |
directories so had to be moved to the correct location.
that hte content of each was fundamentally the same as the original
because the original is a symbolic link.
changes
Author checklist (to be completed by original Author)
Rocky Documentation checklist (to be completed by Rocky team)