Skip to content

Conversation

sspencerwire
Copy link
Contributor

@sspencerwire sspencerwire commented Nov 1, 2021

  • no problems with the translations, BUT, they were put into the wrong
    directories so had to be moved to the correct location.
  • each document had a cursory check with Google Translate to make sure
    that hte content of each was fundamentally the same as the original
  • removed the README.it.md translation as we can't really do this as yet
    because the original is a symbolic link.
  • A new PR for the mkdocs.yml file will need to be merged prior to these
    changes

Author checklist (to be completed by original Author)

  • Is this document a good fit for the Rocky project ?
  • Is this a non-English contribution?
  • Title and Author MetaTags have been inserted into the document
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (to be completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

ambaradan and others added 6 commits October 30, 2021 18:40
Italian translation of Rocky Linux Documentation
* no problems with the translations, BUT, they were put into the wrong
directories so had to be moved to the correct location.
* each document had a cursory check with Google Translate to make sure
that hte content of each was fundamentally the same as the original
* removed the README.it.md translation as we can't really do this as yet
because the original is a symbolic link.
* A new PR for the mkdocs.yml file will need to be merged prior to these
changes
@sspencerwire sspencerwire changed the base branch from edit_335 to main November 1, 2021 15:24
@sspencerwire
Copy link
Contributor Author

Good day @ambaradan I've worked through the translations and they all look good. The README.it.md file was removed based on my comments yesterday. A couple of additional suggestions for you for future PR's:

  • try to keep the document translation in the same folder as the original. For instance, most of your translation files should have been in docs/books/admin_guide/ ... the editor can move them, as I've done, but it is much less error-prone to have them in the correct spot to begin with. This is why you had to create books_index.it.md too, as that file needed to be index.it.md, but in the /docs/books/ folder.

I'm holding the merge of this PR as we need to enable the Italian language in our MkDocs implementation. That should be completed later today and then I'll merge this.

Thanks again for your contributions!!

@ambaradan
Copy link
Contributor

ambaradan commented Nov 1, 2021 via email

@sspencerwire
Copy link
Contributor Author

@ambaradan So sorry to keep you waiting for this merge, but the language was officially added today, so I'm merging this now. Thanks again for your contribution! I'm looking forward to seeing more work from you in the future. ;-) Thanks, Steve

@sspencerwire sspencerwire merged commit 771a631 into rocky-linux:main Nov 3, 2021
@ambaradan
Copy link
Contributor

No problem for the delay, the important thing is that they are useful to someone. Regarding further translations are already in the work....
Thank you

@sspencerwire sspencerwire deleted the edit_335 branch November 4, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants