Skip to content

Conversation

jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented Oct 16, 2021

Author checklist (to be completed by original Author)

  • Is this document a good fit for the Rocky project ?
  • Is this a non-English contribution?
  • Title and Author MetaTags have been inserted into the document
  • If applicable, steps and instructions have been tested to work on a real system
  • Did you perform an initial self-review to fix basic typos and grammatical correctness

Rocky Documentation checklist (to be completed by Rocky team)

  • 1st Pass (Check that document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Basic Editorial Review)
  • 4th Pass (Detailed Editorial Review and Peer Review)
  • 5th Pass (Include document in TOC)
  • Final pass/approval (Final Review)

@sspencerwire
Copy link
Contributor

@jimcat8 Wow! Nice job! What I will likely do is create an English version of this document at the same time prior to merging both. A couple of things that you need to correct if you would. I would fix them, but I won't do justice to your language.

  • In this case, you should be using the author: meta instead of the contributor: meta.
  • put "htop" in a code block like you did "top"... htop instead of just htop.
  • put a space after htop in the primary heading. Currently (translated) that looks like "# htopinstall"
  • there can only be one top level header (#) so your "End" header needs to be ##.
  • Also, it's perfectly fine in the ## End section text to start the sentence with the code block htop and go ahead and put top in that sentence in code block too (top).

Also, one suggestion: shorten the title meta to just "htop - Process Management" this will make it display better in the side menu.

Nice job!!!
Steve

@sspencerwire
Copy link
Contributor

@jimcat8... just one fix the meta that you have is "auther:" this should be "author:" do you want me to fix or do you want to just push through one more change?

@sspencerwire sspencerwire changed the base branch from main to fix_305 October 16, 2021 15:54
@sspencerwire sspencerwire merged commit 6326bb3 into rocky-linux:fix_305 Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants