Skip to content

Conversation

metalllinux
Copy link
Contributor

@metalllinux metalllinux commented Dec 10, 2024

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@jamesbooker
Copy link

Typo at the bottom:

"Then point the mkkiso command directly to the repository directory and build the ISO:"

Should read mkksiso?

@metalllinux
Copy link
Contributor Author

Hi @jamesbooker and thank you very kindly for taking the time out to go through the guide and for your feedback and yes you're right that should be mkksiso. I will have that changed.

Corrected spelling of mkksiso.
@metalllinux
Copy link
Contributor Author

Thank you again @jamesbooker and the change has been made.

Copy link

Test results for 69207e2:

Number of broken URLs: 4

URL,RESULT,FILENAME
 http://example.org/foo.txt,failed,books/web_services/052-load-balancer-proxies-varnish.md
 https://your.domain.name/install.php,failed,guides/cms/chyrp_lite.md
 http://0.0.0.0:61208/,failed,guides/network/glances_network_monitoring.md
 https://azuremarketplace.microsoft.com/en-us/marketplace/apps/resf.rockylinux-aarch64,failed,guides/cloud/migration-to-new-azure-images.md

Copy link
Contributor

@sspencerwire sspencerwire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @metalllinux. I really do not like folders in the repository that have capital letters in them. If you don't mind, I believe I will change out "ISOs" to simply "isos"... It is a folder after all, so it won't change the meaning of the document. I will also alter the .pages file so that the doc section will read "ISOs". Thank you again!

@sspencerwire sspencerwire merged commit ef63fe0 into rocky-linux:main Dec 10, 2024
3 checks passed
@metalllinux
Copy link
Contributor Author

Hi @sspencerwire and thank you kindly as well for going through this one and for the approval. Not a problem at all and please change the directory name from ISOs to isos!

@metalllinux metalllinux deleted the iso-creation branch December 10, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants