Skip to content

Conversation

msmit5
Copy link
Contributor

@msmit5 msmit5 commented Jul 16, 2023

Fixing inconsistent syntax highlighting in apache-multisite docs.

See #1355

Author checklist (Completed by original Author)

  • [-] Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
    • no metatags in files
  • [-] If applicable, steps and instructions have been tested to work
    • N/A
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@wsoyinka
Copy link
Member

Hi @msmit5 ! Thank you for this PR.
I'm going to double-check for you, but I think these fixes need to done using our translation engine/process (Crowdin) and not directly on the source language files here in github. And if this is the case we'll get you setup with Crowdin if that is the case.

We'll get back to you this week on this.

@sspencerwire
Copy link
Contributor

Hi @msmit5 ! Thank you for this PR. I'm going to double-check for you, but I think these fixes need to done using our translation engine/process (Crowdin) and not directly on the source language files here in github. And if this is the case we'll get you setup with Crowdin if that is the case.

We'll get back to you this week on this.

@wsoyinka is absolutely correct. To fix this PR, just remove the commits that don't relate to the original (source) document. The translation engine will pick up the changes and all the translator will have to do is approve them. Unfortunately, directly changing the translated files outside of our Crowdin interface causes problems within that interface. If you remove those commits (those related to the .it, .fr, and .zh languages) we can merge the change you made to the source and the rest will take care of itself. Please let me know if you have questions!

@msmit5
Copy link
Contributor Author

msmit5 commented Jul 17, 2023

Noted! I'll remove the commits to the translation files. Thanks for the heads up.

@msmit5
Copy link
Contributor Author

msmit5 commented Jul 17, 2023

Hey, @sspencerwire, I reverted the commits to the translations, currently, the only edit is on the main file. Let me know if there is anything else I need to do.

@github-actions
Copy link

Test results for f9db4e1:

Number of broken URLs: 8

URL,RESULT,FILENAME
 https://raw.githubusercontent.com/ansible/ansible/devel/examples/ansible.cfg,failed,books/learning_ansible/01-basic.md
 https://github.com/ansible/ansible/blob/devel/examples/ansible.cfg,failed,books/learning_ansible/01-basic.md
 https://github.com/ansible/ansible/blob/devel/examples/hosts,failed,books/learning_ansible/01-basic.md
 https://raw.githubusercontent.com/ansible/ansible/devel/examples/hosts,failed,books/learning_ansible/01-basic.md
 https://github.com/andrewthiesen,failed,guides/contribute/README.md
 https://ersei.saggis.com/,failed,guides/contribute/README.md
 http://www.flaviosiqueira.com.br/,failed,guides/contribute/README.md
 https://github.com/bdacus01,failed,guides/contribute/README.md

@sspencerwire
Copy link
Contributor

Thanks very much @msmit5 We appreciate it!

@sspencerwire
Copy link
Contributor

@all-contributors add @msmit5 for content

@allcontributors
Copy link
Contributor

@sspencerwire

I've put up a pull request to add @msmit5! 🎉

@sspencerwire sspencerwire merged commit 6754c25 into rocky-linux:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants