Skip to content

Update haproxy_apache_lxd.md (punctuation, grammar, ...) #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2023
Merged

Update haproxy_apache_lxd.md (punctuation, grammar, ...) #1336

merged 3 commits into from
Jul 10, 2023

Conversation

SergeCroise
Copy link
Contributor

@SergeCroise SergeCroise commented Jul 9, 2023 •
edited by sspencerwire
Loading

  • fully qualified ... (FQDN)
  • exit the container
  • This can be done ...

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@SergeCroise SergeCroise marked this pull request as draft July 9, 2023 10:15
@SergeCroise
Update haproxy_apache_lxd.md (FQDN, grammar, ...)
4a320eb 
- fully qualified ... (FQDN)
- exit the container
- This can be done ...
@SergeCroise SergeCroise marked this pull request as ready for review July 9, 2023 10:38
@SergeCroise SergeCroise changed the title Update haproxy_apache_lxd.md (punctuation, ...) Update haproxy_apache_lxd.md (punctuation, grammar, ...) Jul 9, 2023
@SergeCroise
Copy link
Contributor Author

Hello @sspencerwire , @ambaradan ,
please review!
(feel free to overwrite my changes)

sspencerwire
sspencerwire reviewed Jul 9, 2023
View reviewed changes
@sspencerwire
Copy link
Contributor

@SergeCroise This looks good except for that one item. Please review and update that and I'll get this merged. Thank you!!

@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Test results for d08aa4a:

Number of broken URLs: 4

 
URL,RESULT,FILENAME
 http://www.flaviosiqueira.com.br/,failed,guides/contribute/README.md
 https://github.com/bdacus01,failed,guides/contribute/README.md
 https://ersei.saggis.com/,failed,guides/contribute/README.md
 https://github.com/andrewthiesen,failed,guides/contribute/README.md

@SergeCroise SergeCroise marked this pull request as draft July 9, 2023 18:29
@SergeCroise SergeCroise marked this pull request as ready for review July 9, 2023 18:30
@SergeCroise SergeCroise requested a review from sspencerwire July 9, 2023 18:31
wsoyinka
wsoyinka approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@wsoyinka wsoyinka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergeCroise :-)

@wsoyinka wsoyinka merged commit f85453b into rocky-linux:main Jul 10, 2023
@SergeCroise SergeCroise deleted the patch-30 branch August 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsoyinka wsoyinka wsoyinka approved these changes

@sspencerwire sspencerwire Awaiting requested review from sspencerwire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeCroise @sspencerwire @wsoyinka