Change the text "Rocky" to "world" to match the screenshot correctly #1271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the text "Rocky" to "world" to match the screenshot correctly
Test results for e1f4a66:
|
SergeCroise
reviewed
Jun 17, 2023
| @@ -66,23 +66,23 @@ We can write a script to observe the color change. | |||
| # Font color cycle | |||
| for color1 in {31..37} | |||
| do | |||
| echo -e "\033[0;${color1};40m---hello! Rocky---\033[0m" | |||
| echo -e "\033[0;${color1};40m---hello! world---\033[0m" | |||
There was a problem hiding this comment.
Suggested change
| echo -e "\033[0;${color1};40m---hello! world---\033[0m" | |
| echo -e "\033[0;${color1};40m---hello! World---\033[0m" |
| done | ||
|
|
||
| echo "-------" | ||
|
|
||
| # Background color cycle | ||
| for color2 in {40..47} | ||
| do | ||
| echo -e "\033[30;${color2}m---hello! Rocky---\033[0m" | ||
| echo -e "\033[30;${color2}m---hello! world---\033[0m" |
There was a problem hiding this comment.
Suggested change
| echo -e "\033[30;${color2}m---hello! world---\033[0m" | |
| echo -e "\033[30;${color2}m---hello! Rocky world---\033[0m" |
| done | ||
|
|
||
| echo "-------" | ||
|
|
||
| # Cycle of display mode | ||
| for color3 in 0 1 4 5 7 8 | ||
| do | ||
| echo -e "\033[${color3};37;40m---hello! Rocky---\033[0m" | ||
| echo -e "\033[${color3};37;40m---hello! world---\033[0m" |
There was a problem hiding this comment.
Suggested change
| echo -e "\033[${color3};37;40m---hello! world---\033[0m" | |
| echo -e "\033[${color3};37;40m---Hello! Rocky World---\033[0m" |
|
@SergeCroise I understand what @jimcat8 is trying to convey here. He has a screen shot in the gemstone that reflects the original text. Changing it means changing the screenshots too. |
sspencerwire
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the text "Rocky" to "world" to match the screenshot correctly
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)