-
Notifications
You must be signed in to change notification settings - Fork 347
fixes 04-ansible-galaxy.md
#1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* change Observations to Functionality
Holding... may need to add to this as Anna works. |
Test results for 6442a8f:
|
@@ -51,7 +51,7 @@ ansible-galaxy role [import|init|install|login|remove|...] | |||
ansible-galaxy collection [import|init|install|login|remove|...] | |||
``` | |||
|
|||
| Sub-commands | Observations | | |||
| Sub-commands | Functionality | | |||
|--------------|------------------------------------------------------------| | |||
| `init` | generate a skeleton of a new collection. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `init` | generate a skeleton of a new collection. | | |
| `init` | generates a skeleton of a new collection. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a new or of a new collection ?
@@ -36,7 +36,7 @@ The `ansible-galaxy` command manages roles and collections using [galaxy.ansible | |||
ansible-galaxy role [import|init|install|login|remove|...] | |||
``` | |||
|
|||
| Sub-commands | Observations | | |||
| Sub-commands | Functionality | | |||
|--------------|-----------------------------------------------------------| | |||
| `install` | installs a role. | | |||
| `remove` | remove one or more roles. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `remove` | remove one or more roles. | | |
| `remove` | removes one or more roles. | |
Hey @SergeCroise Anna and I just discussed this. Honestly, I think instead of changing the the lines you have changed, we need to change "installs a role" to "install a role" and leave the functionality column all using a singular rather than plural. The plural is hinted at where needed. (in other words) "remove one or more roles" It's either that, or we change them all like:
Which is best? I'm not really sure I know. |
What I'm going to do is merge this as is. I've got a problem I need to resolve associated with this branch anyway. Then we can take a look at fixing these lines so that they are consistent. |
Author checklist (Completed by original Author)
Rocky Documentation checklist (Completed by Rocky team)