Skip to content

Conversation

jimcat8
Copy link
Contributor

@jimcat8 jimcat8 commented May 25, 2023

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@jimcat8 jimcat8 marked this pull request as ready for review May 25, 2023 03:48
@sspencerwire
Copy link
Contributor

@jimcat8... The purpose of formatting of the links is to give as much information about the link as possible. You've suggested replacing upstream link here, with simply [here]. This is the recommended action:
"Links, or urls, should tell the user exactly where they'll go if they click on them." We've attempted to do that w/o actually naming the upstream. @NeilHanlon Would you mind taking a look at the other changes suggested here?

@jimcat8
Copy link
Contributor Author

jimcat8 commented May 25, 2023

@jimcat8... The purpose of formatting of the links is to give as much information about the link as possible. You've suggested replacing upstream link here, with simply [here]. This is the recommended action: "Links, or urls, should tell the user exactly where they'll go if they click on them." We've attempted to do that w/o actually naming the upstream. @NeilHanlon Would you mind taking a look at the other changes suggested here?

Because that's what the previous text looks like.

@jimcat8 jimcat8 changed the title Hint the translator that no translation is required here Text formatting repair May 25, 2023
Revert link changes and change "Shared Image Gallerie" to "Shared Image Gallery"
missed one!
@sspencerwire
Copy link
Contributor

@jimcat8... The purpose of formatting of the links is to give as much information about the link as possible. You've suggested replacing upstream link here, with simply [here]. This is the recommended action: "Links, or urls, should tell the user exactly where they'll go if they click on them." We've attempted to do that w/o actually naming the upstream. @NeilHanlon Would you mind taking a look at the other changes suggested here?

Because that's what the previous text looks like.

Yes, and that is a behavior that we are trying to correct.

@github-actions
Copy link

Test results for 0932025:

Number of broken URLs: 1

URL,RESULT,FILENAME
 https://waf.comodo.com,failed,guides/web/apache_hardened_webserver/modsecurity.md

@sspencerwire
Copy link
Contributor

@jimcat8 I've reverted the link changes in your PR, but the additional information you provided is correct (other than the spelling of "Gallery" which I've fixed.) In a plural, "galleries" would be correct, but in this instance it should be singular. https://learn.microsoft.com/en-us/azure/virtual-machines/shared-image-galleries?tabs=azure-cli

@sspencerwire sspencerwire merged commit 37dd5c0 into rocky-linux:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants