Skip to content

review: AD integration #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 15, 2023
Merged

review: AD integration #1070

merged 5 commits into from
Feb 15, 2023

Conversation

alemorvan
Copy link
Contributor

@alemorvan alemorvan commented Feb 15, 2023 •
edited by sspencerwire
Loading

Author checklist (Completed by original Author)

  • Good fit for the Rocky Linux project? Title and Author Metatags inserted ?
  • If applicable, steps and instructions have been tested to work
  • Initial self-review to fix basic typos and grammar completed

Rocky Documentation checklist (Completed by Rocky team)

  • 1st Pass (Document is good fit for project and author checklist completed)
  • 2nd Pass (Technical Review - check for technical correctness)
  • 3rd Pass (Detailed Editorial Review and Peer Review)
  • Final approval (Final Review)

@sspencerwire
Copy link
Contributor

Thank you @alemorvan and @SergeCroise! @Grammaresque would you mind taking a look at this and making any suggestions you might have on it?

@github-actions
Copy link

Test results for 61cd104:

Number of broken URLs: 3

 
URL,RESULT,FILENAME
 https://www.comodo.com/,failed,guides/web/apache_hardened_webserver/modsecurity.md
 https://certbot.eff.org/lets-encrypt/centosrhel8-apache.html,failed,guides/security/generating_ssl_keys_lets_encrypt.md
 http://www.flaviosiqueira.com.br/,failed,guides/contribute/README.md

@sspencerwire sspencerwire merged commit 62d3b1a into rocky-linux:main Feb 15, 2023
@alemorvan alemorvan deleted the ad_review branch May 29, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grammaresque Grammaresque Grammaresque left review comments

@sspencerwire sspencerwire sspencerwire approved these changes

+1 more reviewer

@SergeCroise SergeCroise SergeCroise left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alemorvan @sspencerwire @SergeCroise @Grammaresque