fix: Encode hex strings length <16 to match rippled #133

natenichols · 2021-06-08T19:22:35Z

High Level Overview of Change

Fixes #132.

When rippled decodes Uint64's, it removes leading zeros. This causes issues when encoding JSON objects with ripple-binary-codec.

This PR allows for Uint64's to be hex strings with length 0-16, and then pads leading zeros up to length 16.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Tests (You added tests for code that already exists, or your new feature included in this PR)
Documentation Updates
Release

Adds tests for ledger entries described in #132

intelliot

LGTM

fix: Encode hex strings length <16 to match rippled

3c9fc72

natenichols requested a review from intelliot June 8, 2021 19:22

intelliot approved these changes Jun 8, 2021

View reviewed changes

natenichols merged commit a3e67a7 into master Jun 8, 2021

natenichols deleted the uint64-parse-hex branch June 8, 2021 23:40

ledhed2222 pushed a commit that referenced this pull request Oct 13, 2021

fix: Encode hex strings length <16 to match rippled (#133)

52728e8