This repository was archived by the owner on Nov 24, 2021. It is now read-only.
fix: edge case construcing from string '0' #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good... could we also add a test case that uses some realistic-ish data from rippled? Since this is covering a case that only occurs as of rippled v1.7.0+ |
ledhed2222
pushed a commit
that referenced
this pull request
Oct 13, 2021
* fix: edge case constructing from string '0'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Handles the edge case where
UInt64is constructed from string'0'.Context of Change
When constructing
UInt64with.from(), this adds an edge case when the parameter is of type string whereUInt64.from('0')returnsUInt64.from(0).Type of Change
Test Plan
Added test coverage for this case.