fix(tailwind): media queries not getting sanitized sometimes #1929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 845dae5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
27a99ba to
8dfb96a
Compare
gabrielmfern
force-pushed
the
canary
branch
7 times, most recently
from
ceeaf0d to
e7c671a
Compare
gabrielmfern
force-pushed
the
canary
branch
4 times, most recently
from
c740494 to
b114121
Compare
gabrielmfern
force-pushed
the
canary
branch
7 times, most recently
from
643b95a to
35a000c
Compare
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
be584c9 to
0ab0f29
Compare
gabrielmfern
force-pushed
the
canary
branch
4 times, most recently
from
addf436 to
ade5f69
Compare
gabrielmfern
force-pushed
the
canary
branch
4 times, most recently
from
3ff8597 to
3c4ea0a
Compare
gabrielmfern
force-pushed
the
fix/tailwind-not-extracting-media-queries
branch
from
75f1cab to
7c5cd2a
Compare
commit: |
gabrielmfern
changed the title
gabrielmfern
changed the title
gabrielmfern
requested review from
pedro-stramantinoli
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1871. The issue there is pretty clear on what the problem they were having was, the problem particularly was that the internal
candidateRuleCachefrom Tailwind was not being cleared. This pull request also adds in a test to ensure that this is working and that there are no future regressions on this.react-email/packages/tailwind/src/utils/tailwindcss/setup-tailwind.ts
Line 27 in 5344b1e
The above line is the actual fix, it literally sets the cache as empty before doing any of the class-to-style resolution.
The specific issue was that the first time a class like
dark:...(i.e., a class to insert into the user's<Head>), it worked just fine, but then the second time the same exact class was used again, it seems to simply ignore it, and not do the transformations that are needed.