Skip to content

Conversation

markdalgleish
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Aug 29, 2025

🦋 Changeset detected

Latest commit: f22fcc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish marked this pull request as ready for review August 29, 2025 07:12
false,
),
location: payload.location,
basename: payload.basename,
Copy link
Member Author

@markdalgleish markdalgleish Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't obvious that the basename wasn't being passed through because of the positional args, so I've refactored the getHydrationData function to use an options object instead.

@markdalgleish markdalgleish merged commit 6133e51 into dev Aug 29, 2025
8 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/rsc-framework-mode-basename branch August 29, 2025 21:03
Copy link
Contributor

github-actions bot commented Sep 9, 2025

🤖 Hello there,

We just published version 7.9.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.9.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants