Skip to content

Conversation

BRUHItsABunny
Copy link
Contributor

Fixes #344

@Juktong
Copy link
Contributor

Juktong commented May 21, 2025

Hi @BRUHItsABunny,

Thanks for this PR! I'm new to the uTLS codebase and have been reading through it, hoping to contribute.

I've reviewed the CookieExtension code changes in this PR and they correctly align with RFC 8446. To aid understanding (initially for myself, but hopefully for future readers too!), I've added a brief comment to the Len() method for cookie extension on my fork to clarify the byte layout.

You can see the suggested comment in this commit:
7daac69

If you find it useful, please feel free to incorporate it.

@BRUHItsABunny
Copy link
Contributor Author

Nice contribution, I've included it. @Juktong

@mingyech How do we go forward on this PR? On my end this seems to work really well, is there anything else I should do?

Copy link
Member

@mingyech mingyech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and worked well in my tests, thanks everyone!

@mingyech mingyech force-pushed the fix/malformed-cookie-extension branch from 7daac69 to 41ce3ba Compare June 9, 2025 20:32
@mingyech mingyech merged commit 41ce3ba into refraction-networking:master Jun 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS cookie issue visiting URL
3 participants