-
Notifications
You must be signed in to change notification settings - Fork 297
Implement Chrome 133+ support #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since the previous codepoints are coded in file exttype_values.go, it would be a good idea to also update it as well. |
I noticed some TLS errors especially on Google domains while using my branch. I have updated it to support the new application settings code point in the ECH as well to fix those errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, added some suggestions
rename ApplicationSettingsExtension to applicationSettingsExtension break my exist custom spec |
Just duplicating the ApplicationSettingsExtension would be cleaner. These changes force unnecessary updates to too many spec settings. |
I understand, some of my own modules also broke with those changes and wasn't sure if that was the expectation with the approach that was requested. |
Ooo yeah we should be careful with compatibility, thanks for pointing out @RonaldinhoL @BRUHItsABunny This new change looks good though, looks like nothing will be broken |
this not work for me, my specs are defined out of utls lib, applicationSettingsExtension is not exposed. |
I don't think it will require outside changes though? applicationSettingsExtension will be auto initialized with the exported versions |
Could you provide an example of what you are trying to do? With the new changes this doesn't panic anymore. |
Added 4241c5b to make clear that this will not break backward compatibility, but let me know if there's something else broken by this
Good idea yeah I'll do some squashing when merging |
Thanks for carrying it over the finish line @mingyech |
Since Chrome 133 the TLS fingerprint is changing due to this feature:
https://chromestatus.com/feature/5149147365900288
I found that others are also running into this problem here: #330
It looks like a "full" implementation might be bigger than just extending the current application settings extension, as per another implementation here:
bogdanfinn/utls@fe91add
Opening this PR as a draft to discuss how we should move forward on this, I've also implemented this for the time being as it might be enough to address this (at least for my use case)