Skip to content

fix(ts): xtrim threshold accepts string #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025
+16 −1
Merged

fix(ts): xtrim threshold accepts string #3058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb68e1
fix(ts): xtrim threshold accepts string
Eomm Sep 5, 2024
b2f361b
test: check MINID with text id
Eomm Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packages/client/lib/commands/XTRIM.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ describe('XTRIM', () => {
parseArgs(XTRIM, 'key', 'MINID', 123),
['XTRIM', 'key', 'MINID', '123']
);

assert.deepEqual(
parseArgs(XTRIM, 'key', 'MINID', '0-0'),
['XTRIM', 'key', 'MINID', '0-0']
);
});

it('with strategyModifier', () => {
Expand Down Expand Up @@ -89,6 +94,16 @@ describe('XTRIM', () => {
cluster: GLOBAL.CLUSTERS.OPEN,
});

testUtils.testAll('xTrim with string MINID', async client => {
assert.equal(
typeof await client.xTrim('key', 'MINID', '0-0'),
'number'
);
}, {
client: GLOBAL.SERVERS.OPEN,
cluster: GLOBAL.CLUSTERS.OPEN,
});

testUtils.testAll(
'xTrim with LIMIT',
async (client) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/client/lib/commands/XTRIM.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default {
parser: CommandParser,
key: RedisArgument,
strategy: 'MAXLEN' | 'MINID',
threshold: number,
threshold: number | string,
options?: XTrimOptions
) {
parser.push('XTRIM')
Expand Down
Loading