-
Notifications
You must be signed in to change notification settings - Fork 48
Add wait until cluster is stable prior to post-cluster-install tasks #627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wait until cluster is stable prior to post-cluster-install tasks #627
Conversation
Skipping CI for Draft Pull Request. |
/test deploy-5nodes |
1 similar comment
/test deploy-5nodes |
Test failed because the timeout was too short, I suggest adjusting according to the timeouts that we have in Prow. |
Got it, I'll try those defaults here with the goal of seeing how long it normally takes a cluster to become stable, I don't really like the idea of adding up to 20m to the length of the playbook so I might default the action to false |
/test deploy-5nodes |
Having a 20 minutes timeout doesn't mean it's going to add 20 minutes always to the total time, if the cluster is healthy before for 2 minutes then it won't take the full timeout time. |
Understood, but in theory, it could add up to 20m to tell you that there is a non-stable cluster as well. Some folks don't bother to play with something until they see the current playbook etc run to completion. Also could make CI jobs run 20m to tell you about an unstable cluster. Having ran many tests from jetlag MNO clusters before I actually wasn't even aware all the time that there was still some amount of cluster operator work occurring post assisted installer saying the cluster completed installing. |
Most recent run added 7m and 40s to an MNO deployment, but should ensure that the cluster is stable for day2 operations post deployment: mno-post-cluster-install : Wait until cluster is stable --------------- 460.44s |
/test deploy-sno |
/test deploy-5nodes |
On my own SNO I observed 5m and 30s to wait for the cluster to become stable. sno-post-cluster-install : Wait until cluster is stable ------------------------------------------ 330.39s |
/lgtm |
/test deploy-sno |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akrzos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ea12e85
into
redhat-performance:main
No description provided.