Skip to content

Conversation

akrzos
Copy link
Member

@akrzos akrzos commented Sep 30, 2024

No description provided.

@akrzos akrzos requested review from dbutenhof and radez September 30, 2024 19:00
Copy link
Collaborator

@dbutenhof dbutenhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor observations, but I won't object.

README.md Outdated
| SNO | Single Node OpenShift | 1 OpenShift Master/Worker Node "cluster" per available hardware resource

Each cluster layout requires a bastion machine which is the first machine out of your lab "cloud" allocation. The bastion machine will host the assisted-installer service and serve as a router for clusters with a private machine network. BM and RWN layouts produce a single cluster consisting of 3 control-plane nodes and X number of worker or remote worker nodes. The worker node count can also be 0 such that your bare metal cluster is a compact 3 node cluster with schedulable control-plane nodes. SNO layout creates an SNO cluster per available machine after fulfilling the bastion machine requirement. Lastly, BM/RWN cluster types will allocate any unused machines under the `hv` ansible group which stands for hypervisor nodes. The `hv` nodes can host vms for additional clusters that can be deployed from the hub cluster. (For ACM/MCE testing)
Each cluster layout requires a bastion machine which is the first machine out of your lab "cloud" allocation. The bastion machine will host the assisted-installer service and serve as a router for clusters with a private machine network. BM produces a single cluster consisting of 3 control-plane nodes and X number of worker nodes. The worker node count can also be 0 such that your bare metal cluster is a compact 3 node cluster with schedulable control-plane nodes. SNO layout creates an SNO cluster per available machine after fulfilling the bastion machine requirement. Lastly, BM cluster can allocate any unused machines under the `hv` ansible group which stands for hypervisor nodes. The `hv` nodes can host vms for additional clusters that can be deployed from the hub cluster. (For ACM/MCE testing)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"can" is not quite a replacement for "cluster types will". Maybe, "a BM cluster" or "the BM cluster type"?

Copy link
Collaborator

@radez radez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be rebased on the bm_to_mno patch?
I've been trying to keep that patch clean to go in and it's been waiting a while.

This patch will create lots of conflicts in that patch.

@akrzos akrzos marked this pull request as ready for review October 2, 2024 18:08
@akrzos akrzos requested a review from dbutenhof October 2, 2024 18:08
@radez
Copy link
Collaborator

radez commented Oct 2, 2024

lgtm

@akrzos akrzos merged commit 3e7727d into redhat-performance:main Oct 2, 2024
@akrzos akrzos deleted the remove_rwn branch October 2, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants