-
Notifications
You must be signed in to change notification settings - Fork 301
fix: default snippet in array #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: default snippet in array #755
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts
Hello, I merged the code and resolved conflicts, there were some problems with the test. I left a little bit related comment here in this PR https://github.com/redhat-developer/yaml-language-server/pull/786/files#r1029764436 |
What does this PR do?
Fixes an issue where default snippets where not being entered correctly within an array.
Given the following schema:
When autocomplete is attempted on:
It previously autocompleted to:
After the fix it correctly indents as:
What issues does this PR fix or reference?
no ref
Is it tested? How?
Manual testing and unit test.