Make the directory structures for ESM, UMD, and CJS the same #1125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump to 2.0.0, since this is a breaking change - Do not compile the test code explicitly; it's compiled through ts-node in the background - Also remove executable from random files that shouldn't be executable Fixes redhat-developer#1124 Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
make-build-directories-similar
branch
from
e4ecf3b to
a12340f
Compare
datho7561
added a commit
to datho7561/vscode-yaml
that referenced
this pull request
Sep 11, 2025
Adapt to the new location of the built code. Signed-off-by: David Thompson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
./out/server/src/server.jsis gone but now available at./lib/cjs/server.js. This makes the directory structure for the CJS, UMD, and ESM builds the same.chmod u-xforREADME.mdandtsconfig.json, since they're not actually executable programsWhat issues does this PR fix or reference?
Fixes #1124
Is it tested? How?
CI