Update to latest version of Argo Rollouts Route plugin E2E tests on 'master' branch #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…master' branch Signed-off-by: Jonathan West <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetan-rns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 41cfddb
into
redhat-developer:master
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
A fix for a race condition in the Argo Rollouts Route plugin E2E tests was made as part of argoproj-labs/rollouts-plugin-trafficrouter-openshift@1495bba
This PR adopts that commit to run it as part of gitops-operator rollouts E2E tests.
Note: This test doesn't currently run as part of PR E2E tests, but I have verified it manually, locally against
masterbranch.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer: