fix CVE namespace-isolation break #853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argocd adds cluster monitoring label if the ns contains openshift- prefix Signed-off-by: Anand Kumar Singh <[email protected]>
|
/retest |
|
/lgtm |
|
/lgtm |
|
/retest |
|
/retest |
|
/lgtm |
|
@anandrkskd: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iam-veeramalla, varshab1210 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
openshift-merge-bot
bot
merged commit 08ff6ac
into
redhat-developer:master
17 checks passed
varshab1210
pushed a commit
to nmirasch/gitops-operator
that referenced
this pull request
Jul 23, 2025
argocd adds cluster monitoring label if the ns contains openshift- prefix Signed-off-by: Anand Kumar Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
argocd adds cluster monitoring label if the ns contains openshift- prefix
What type of PR is this?
/kind bug
What does this PR do / why we need it:
This PR fixes the namespace isolation break, caused by using cluster-monitoring label for monitoring
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes GITOPS-6251
Test acceptance criteria:
How to test changes / Special notes to the reviewer: