Skip to content

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jan 17, 2025

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:

I noticed that this test was failing in another PR:

�[91m�[1m[Fail] �[0m�[90mArgo CD metrics controller �[0m�[0mCheck if monitoring resources are created �[0m�[91m�[1m[It] Role is created �[0m
�[37m/go/src/github.com/redhat-developer/gitops-operator/test/e2e/argocd_metrics_test.go:42�[0m

However, it was not obvious why, because the output from oc is not printed in the failing case. This PR updates the command execution logic to output console stdout/stderr, so if this error occurs again we can know why.

Copy link

openshift-ci bot commented Jan 17, 2025

@jgwest: The label(s) kind/code-refactoring cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind code-refactoring

What does this PR do / why we need it:

I noticed that this test was failing in another PR:

�[91m�[1m[Fail] �[0m�[90mArgo CD metrics controller �[0m�[0mCheck if monitoring resources are created �[0m�[91m�[1m[It] Role is created �[0m
�[37m/go/src/github.com/redhat-developer/gitops-operator/test/e2e/argocd_metrics_test.go:42�[0m

However, it was not obvious why, because the output from oc is not printed in the failing case. This PR updates the command execution logic to output console stdout/stderr, so if this error occurs again we can know why.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgwest
Copy link
Member Author

jgwest commented Jan 17, 2025

/retest

failed to run bundle: error waiting for CSV to install: timed out waiting for the condition\n"
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-01-17T16:18:15Z"} ```

@jparsai
Copy link
Collaborator

jparsai commented Feb 3, 2025

/lgtm

@jannfis
Copy link
Member

jannfis commented Feb 3, 2025

/lgtm

@jannfis
Copy link
Member

jannfis commented Feb 3, 2025

/approve

Copy link

openshift-ci bot commented Feb 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jannfis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 6990358 into redhat-developer:master Feb 3, 2025
17 checks passed
varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants