Skip to content

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Nov 12, 2024

Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@9f79ece

Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member Author

jgwest commented Nov 12, 2024

Cluster init error

/retest

1 similar comment
@jgwest
Copy link
Member Author

jgwest commented Nov 13, 2024

Cluster init error

/retest

@jgwest
Copy link
Member Author

jgwest commented Nov 18, 2024

/retest

1 similar comment
@Rizwana777
Copy link
Collaborator

/retest

@jparsai
Copy link
Collaborator

jparsai commented Nov 26, 2024

@jgwest LGTM, but need to resolve conflicts.

@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from c8980da to 10018e5 Compare November 26, 2024 13:26
@Rizwana777
Copy link
Collaborator

/retest

@Rizwana777
Copy link
Collaborator

Adding an commit will fix the failing pipeline, earlier integration tests were running for all the components as I have not added a context only to run integration tests for argo-rollouts-cli, Now I have fixed it

@jgwest
Copy link
Member Author

jgwest commented Nov 28, 2024

Thanks @jparsai and thanks @Rizwana777!

@jgwest jgwest merged commit 3b5b621 into redhat-developer:master Nov 28, 2024
16 of 18 checks passed
varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants