Skip to content

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Nov 6, 2024

What does this PR do / why we need it:
Bump golang to 1.22

Signed-off-by: Siddhesh Ghadi <[email protected]>
@svghadi
Copy link
Member Author

svghadi commented Nov 6, 2024

/retest

1 similar comment
@svghadi
Copy link
Member Author

svghadi commented Nov 7, 2024

/retest

@iam-veeramalla
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 7, 2024
@svghadi
Copy link
Member Author

svghadi commented Nov 7, 2024

@varshab1210 - Are these known failures?

        --- FAIL: kuttl/harness/1-067_validate_redis_secure_comm_no_autotls_ha (162.10s)
        --- FAIL: kuttl/harness/1-066_validate_redis_secure_comm_no_autotls_no_ha (37.84s)

@varshab1210
Copy link
Member

@varshab1210 - Are these known failures?

        --- FAIL: kuttl/harness/1-067_validate_redis_secure_comm_no_autotls_ha (162.10s)
        --- FAIL: kuttl/harness/1-066_validate_redis_secure_comm_no_autotls_no_ha (37.84s)

req: Multiple digest or unknown options: -sha256 and -sha256

Could you please remove one of the sha256 options? That should fix the failure

Signed-off-by: Siddhesh Ghadi <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Nov 7, 2024
@svghadi
Copy link
Member Author

svghadi commented Nov 7, 2024

/retest

2 similar comments
@svghadi
Copy link
Member Author

svghadi commented Nov 8, 2024

/retest

@svghadi
Copy link
Member Author

svghadi commented Nov 8, 2024

/retest

@varshab1210
Copy link
Member

LGTM, thanks

@varshab1210
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit afcbfa4 into redhat-developer:master Nov 8, 2024
23 checks passed
@svghadi svghadi deleted the go-1.22 branch November 8, 2024 11:01
varshab1210 pushed a commit to nmirasch/gitops-operator that referenced this pull request Jul 23, 2025
* Bump go to 1.22

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Fix kuttl test

Signed-off-by: Siddhesh Ghadi <[email protected]>

---------

Signed-off-by: Siddhesh Ghadi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants