Skip to content

Conversation

saumeya
Copy link
Member

@saumeya saumeya commented Aug 20, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from anandrkskd and jgwest August 20, 2024 11:39
@saumeya saumeya requested review from anandf and svghadi and removed request for jgwest and anandrkskd August 20, 2024 11:40
@svghadi
Copy link
Member

svghadi commented Aug 20, 2024

CRDs need to be updated here: https://github.com/redhat-developer/gitops-operator/tree/master/config/crd/bases.

Copy all the CRDs except argocdexports from https://github.com/argoproj-labs/argocd-operator/tree/v0.12.0-rc1/config/crd/bases.

@jgwest - Do rollout CRDs need update or they are latest of the required version?

Signed-off-by: saumeya <[email protected]>
@saumeya saumeya requested a review from jgwest August 20, 2024 17:40
@saumeya
Copy link
Member Author

saumeya commented Aug 21, 2024

/retest-required

@saumeya saumeya changed the title chore: update to leatest argocd-operator for 1.14 release chore: update to latest argocd-operator for 1.14 release Aug 21, 2024
@svghadi
Copy link
Member

svghadi commented Aug 21, 2024

Test also needs an update:

# These variables need to be maintained according to the component matrix: https://spaces.redhat.com/display/GITOPS/GitOps+Component+Matrix
expected_kustomizeVersion='v5.2.1'
expected_helmVersion='v3.14.4'
expected_argocdVersion='v2.11.6+089247d'

Signed-off-by: saumeya <[email protected]>
@saumeya
Copy link
Member Author

saumeya commented Aug 22, 2024

/test v4.14-kuttl-parallel

1 similar comment
@saumeya
Copy link
Member Author

saumeya commented Aug 22, 2024

/test v4.14-kuttl-parallel

Signed-off-by: saumeya <[email protected]>
@svghadi
Copy link
Member

svghadi commented Aug 22, 2024

/lgtm

@svghadi
Copy link
Member

svghadi commented Aug 22, 2024

/cherry-pick v1.14

@openshift-cherrypick-robot

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@svghadi
Copy link
Member

svghadi commented Aug 22, 2024

/approve

Copy link

openshift-ci bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 991add7 into redhat-developer:master Aug 22, 2024
20 checks passed
@openshift-cherrypick-robot

@svghadi: new pull request created: #768

In response to this:

/cherry-pick v1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants