Skip to content

Conversation

anandf
Copy link
Member

@anandf anandf commented Aug 13, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug
/kind cleanup
/kind failing-test
/kind enhancement
/kind documentation
/kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

Signed-off-by: Anand Francis Joseph <[email protected]>
Copy link

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anandf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Aug 13, 2024

@anandf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.13-kuttl-parallel 973e4cd link true /test v4.13-kuttl-parallel
ci/prow/v4.14-kuttl-parallel 973e4cd link true /test v4.14-kuttl-parallel
ci/prow/v4.12-kuttl-sequential 973e4cd link true /test v4.12-kuttl-sequential
ci/prow/v4.14-kuttl-sequential 973e4cd link true /test v4.14-kuttl-sequential
ci/prow/v4.13-kuttl-sequential 973e4cd link true /test v4.13-kuttl-sequential

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@svghadi
Copy link
Member

svghadi commented Aug 14, 2024

Thanks @anandf. Since we did not cut the 1.14 branch yet, adding a /hold so that we don't accidentally merge this.

@svghadi
Copy link
Member

svghadi commented Aug 14, 2024

/hold

@svghadi
Copy link
Member

svghadi commented Aug 25, 2024

Thanks @anandf. Closing this in favour of #765

@svghadi svghadi closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants