Skip to content

chore: upgrade operator-sdk to 1.35 #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 18, 2024
Merged

chore: upgrade operator-sdk to 1.35 #748

merged 3 commits into from
Jul 18, 2024

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this?
/kind cleanup

What does this PR do / why we need it:
This PR updates operator-sdk version from 1.32.0 to 1.35.0.

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:

@anandrkskd
chore: upgrade operator-sdk to 1.35
754e1c4 
Signed-off-by: Anand Kumar Singh <[email protected]>
@openshift-ci openshift-ci bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process. do-not-merge/work-in-progress labels Jul 16, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@anandrkskd anandrkskd marked this pull request as ready for review July 17, 2024 05:56
@openshift-ci openshift-ci bot requested review from chetan-rns and keithchong July 17, 2024 05:57
@anandrkskd
Copy link
Contributor Author

/retest

@anandrkskd anandrkskd force-pushed the operator-sdk-upgrade-1.35 branch from 449424f to 2ffa0b5 Compare July 17, 2024 10:08
@saumeya
Copy link
Member

saumeya commented Jul 17, 2024 •
edited
Loading

We are not using internal in gitops-operator either?

saumeya
saumeya reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, else looks good to me. Thanks Anand!

@anandrkskd
Copy link
Contributor Author

We are not using internal in gitops-operator either?

No @saumeya, as per last discussion with you and @svghadi, AFAIR we decided not to make changes to the controllers, as it might affect if other projects are using this repo as dependency.

@svghadi, @iam-veeramalla WDYT?

@svghadi
Copy link
Member

svghadi commented Jul 17, 2024

Yes, let's avoid moving to the internal/ directory structure for now. We can re-evaluate this decision during the refactoring efforts if needed.

svghadi
svghadi reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 17, 2024
@iam-veeramalla
Copy link
Contributor

/lgtm
/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d6d18be into redhat-developer:master Jul 18, 2024
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
@anandrkskd
chore: upgrade operator-sdk to 1.35 (redhat-developer#748)
bedc193 
* chore: upgrade operator-sdk to 1.35

Signed-off-by: Anand Kumar Singh <[email protected]>

* chore: use latest argocd-operator changes

Signed-off-by: Anand Kumar Singh <[email protected]>

* update Dockerfile file to pint to new main.go location

Signed-off-by: Anand Kumar Singh <[email protected]>

---------

Signed-off-by: Anand Kumar Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svghadi svghadi svghadi left review comments

@chetan-rns chetan-rns Awaiting requested review from chetan-rns

@keithchong keithchong Awaiting requested review from keithchong

+1 more reviewer

@saumeya saumeya saumeya left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@iam-veeramalla iam-veeramalla

@svghadi svghadi

Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process. lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandrkskd @saumeya @svghadi @iam-veeramalla