Skip to content

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jun 12, 2024

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Copy link

openshift-ci bot commented Jun 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member Author

jgwest commented Jun 12, 2024

/test all

1 similar comment
@jgwest
Copy link
Member Author

jgwest commented Jun 13, 2024

/test all

@jgwest
Copy link
Member Author

jgwest commented Jun 14, 2024

/retest

@jgwest jgwest force-pushed the add-rollouts-plugin-to-e2e-tests-jun-2024 branch from 1988043 to 4888978 Compare June 22, 2024 06:16
@jgwest jgwest marked this pull request as ready for review June 22, 2024 06:16
@jgwest
Copy link
Member Author

jgwest commented Jun 25, 2024

/retest

@jgwest jgwest requested review from jparsai and removed request for reginapizza and varshab1210 July 10, 2024 09:02
@jgwest jgwest force-pushed the add-rollouts-plugin-to-e2e-tests-jun-2024 branch from 4888978 to 2ef05cc Compare July 24, 2024 21:21
@jparsai
Copy link
Collaborator

jparsai commented Jul 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 25, 2024
@jgwest jgwest merged commit 0d7f54b into redhat-developer:master Jul 25, 2024
@jgwest jgwest changed the title Add OpenShift Rollouts Route Plugin E2E tests to GitOps Operator tests Add OpenShift Rollouts Route Plugin E2E tests to Rollouts tests Jul 25, 2024
@jgwest
Copy link
Member Author

jgwest commented Jul 25, 2024

Thanks @jparsai!

trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants