Skip to content

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented Jun 10, 2024

What type of PR is this?
/kind bug

What does this PR do / why we need it:

When using pre-release builds, when you create an Argo Rollouts (install by creating a RolloutManager CR) the Rollouts Pod that is created will fail to start.

If you look at the Pods logs for the Rollout controller, you will see the following error:

[jgw@localhost-lan rollouts-plugin-trafficrouter-openshift]$ k logs pod/argo-rollouts-7bcddf67cf-hl8ph
time="2024-06-10T12:46:22Z" level=info msg="Argo Rollouts starting" version=vstable+737ca89
time="2024-06-10T12:46:22Z" level=info msg="Creating event broadcaster"
time="2024-06-10T12:46:22Z" level=info msg="Setting up event handlers"
time="2024-06-10T12:46:22Z" level=info msg="Setting up experiments event handlers"
time="2024-06-10T12:46:22Z" level=info msg="Setting up analysis event handlers"
time="2024-06-10T12:46:22Z" level=fatal msg="Failed to download plugins: plugin location must be of http(s) or file scheme"

The fix is a one line change to gitops-operator. The ConfigMap that is generated SHOUD contain this:

  trafficRouterPlugins: |
    - name: argoproj-labs/openshift
      location: file:/plugins/rollouts-trafficrouter-openshift/openshift-route-plugin
      sha256: ""

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Jun 10, 2024
@jgwest jgwest changed the title Fix Rollouts plugin location URL format Fix Rollouts plugin location URL format (master branch) Jun 10, 2024
@openshift-ci openshift-ci bot requested review from jaideepr97 and sbose78 June 10, 2024 13:22
Copy link

openshift-ci bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest
Copy link
Member Author

jgwest commented Jun 10, 2024

Red Hat Issue Tracker: https://issues.redhat.com/browse/GITOPS-4815

@jgwest
Copy link
Member Author

jgwest commented Jun 10, 2024

/retest

cluster flake

@jgwest jgwest merged commit 841bc0e into redhat-developer:master Jun 11, 2024
@jgwest
Copy link
Member Author

jgwest commented Jun 11, 2024

LGTM by Anand on the other PR

trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant