Skip to content

Conversation

jgwest
Copy link
Member

@jgwest jgwest commented May 23, 2024

Update to most recent 'argo-rollouts-manager' commit: argoproj-labs/argo-rollouts-manager@b3e573f

@openshift-ci openshift-ci bot requested review from ciiay and reginapizza May 23, 2024 09:05
Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgwest jgwest force-pushed the upgrade-rollouts-manager branch 3 times, most recently from bd5bf93 to 246f73f Compare May 24, 2024 11:30
@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from a2ae335 to af2f29e Compare May 24, 2024 14:36
@jgwest
Copy link
Member Author

jgwest commented May 25, 2024

/retest

@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from f0dce6a to 8c6dd83 Compare May 25, 2024 19:30
@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from 8c6dd83 to 71c98fe Compare May 25, 2024 21:32
@jgwest jgwest changed the title Update to latest commit of argo-rollouts-manager 'c132cfa3b12975c44d7397009ea7351f9f386e82' Update to latest commit of argo-rollouts-manager 'b3e573f0e6ea3a5ec3eeba70ebb5d90e58efcd68' May 25, 2024
@jgwest
Copy link
Member Author

jgwest commented May 26, 2024

/retest

2 similar comments
@jgwest
Copy link
Member Author

jgwest commented May 26, 2024

/retest

@jgwest
Copy link
Member Author

jgwest commented May 27, 2024

/retest

@jgwest jgwest force-pushed the upgrade-rollouts-manager branch from 8783a40 to 71c98fe Compare May 27, 2024 05:26
@jgwest
Copy link
Member Author

jgwest commented May 27, 2024

/retest

Copy link

openshift-ci bot commented May 27, 2024

@jgwest: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-kuttl-sequential 71c98fe link true /test v4.14-kuttl-sequential
ci/prow/v4.12-kuttl-parallel 71c98fe link true /test v4.12-kuttl-parallel
ci/prow/v4.14-kuttl-parallel 71c98fe link true /test v4.14-kuttl-parallel
ci/prow/v4.13-kuttl-parallel 71c98fe link true /test v4.13-kuttl-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgwest
Copy link
Member Author

jgwest commented May 27, 2024

Merging as I've confirmed that the tests that are failing are due to redis changes (or cluster infra issues) which will be fixed by #719.

@jgwest jgwest merged commit 03612ed into redhat-developer:master May 27, 2024
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…eba70ebb5d90e58efcd68' (redhat-developer#718)

* Update to latest commit of argo-rollouts-manager 'c132cfa3b12975c44d7397009ea7351f9f386e82'

Signed-off-by: Jonathan West <[email protected]>

* Add CRD to scheme, enable namespace-scoped hooks

Signed-off-by: Jonathan West <[email protected]>

---------

Signed-off-by: Jonathan West <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant