Skip to content

Conversation

Rizwana777
Copy link
Collaborator

What type of PR is this?
Remove workaround from e2e tests related to issue #148

@openshift-ci openshift-ci bot requested review from reginapizza and sbose78 April 30, 2024 07:53
Copy link

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jannfis for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 30, 2024

Hi @Rizwana777. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Rizwana777
Copy link
Collaborator Author

@jgwest
Copy link
Member

jgwest commented May 1, 2024

/ok-to-test

@jgwest jgwest requested review from jgwest and removed request for sbose78 and reginapizza May 1, 2024 00:39
@varshab1210
Copy link
Member

/test v4.12-kuttl-sequential

@varshab1210
Copy link
Member

/test v4.13-e2e

@varshab1210
Copy link
Member

/test v4.12-kuttl-sequential

@varshab1210
Copy link
Member

/test v4.13-e2e

@jgwest jgwest force-pushed the issue-1090-remove-workaround branch from 86ec27e to ca2933e Compare May 8, 2024 17:40
@jgwest
Copy link
Member

jgwest commented May 9, 2024

/retest

Copy link
Member

@jgwest jgwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwest jgwest merged commit cc8c4a7 into redhat-developer:master May 9, 2024
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants