Skip to content

Conversation

saumeya
Copy link
Member

@saumeya saumeya commented Apr 24, 2024

What type of PR is this?

Uncomment only one /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind bug

What does this PR do / why we need it:

Have you updated the necessary documentation?

  • Documentation update is required by this PR.
  • Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

Test acceptance criteria:

  • Unit Test
  • E2E Test

How to test changes / Special notes to the reviewer:
Enable runOnInfra: true in GitOpsService CR
And verify that the console-plugin pods has the correct nodeSelector label added to it.

@openshift-ci openshift-ci bot requested review from chetan-rns and wtam2018 April 24, 2024 11:08
Copy link

openshift-ci bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chetan-rns for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@anandf anandf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Apr 24, 2024

@saumeya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.12-e2e d3cbc1a link true /test v4.12-e2e
ci/prow/v4.12-kuttl-parallel d3cbc1a link true /test v4.12-kuttl-parallel
ci/prow/v4.12-kuttl-sequential d3cbc1a link true /test v4.12-kuttl-sequential
ci/prow/v4.13-kuttl-parallel d3cbc1a link true /test v4.13-kuttl-parallel
ci/prow/v4.13-kuttl-sequential d3cbc1a link true /test v4.13-kuttl-sequential
ci/prow/v4.13-e2e d3cbc1a link true /test v4.13-e2e
ci/prow/v4.14-kuttl-sequential d3cbc1a link true /test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel d3cbc1a link true /test v4.14-kuttl-parallel
ci/prow/v4.14-e2e d3cbc1a link true /test v4.14-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@saumeya saumeya requested review from svghadi and removed request for chetan-rns and wtam2018 April 24, 2024 13:12
Copy link
Member

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested out the changes. Looks good. Thanks!!

@svghadi
Copy link
Member

svghadi commented Apr 26, 2024

/cherry-pick v1.12

@openshift-cherrypick-robot

@svghadi: once the present PR merges, I will cherry-pick it on top of v1.12 in a new PR and assign it to you.

In response to this:

/cherry-pick v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iam-veeramalla iam-veeramalla merged commit b311569 into redhat-developer:master Apr 28, 2024
@openshift-cherrypick-robot

@svghadi: new pull request created: #681

In response to this:

/cherry-pick v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…e-plugin

fix: enable infra label to console-plugin deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants