Skip to content

Conversation

svghadi
Copy link
Member

@svghadi svghadi commented Dec 19, 2023

What type of PR is this?
/kind documentation

What does this PR do / why we need it:
Update & reorganize new argocd instance creation section in docs

Which issue(s) this PR fixes:

Fixes GITOPS-3527

@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label Dec 19, 2023
Copy link
Member

@saumeya saumeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @svghadi

@anandrkskd
Copy link
Contributor

LGTM!

@iam-veeramalla
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5e0f135 into redhat-developer:master Jul 29, 2024
@svghadi svghadi deleted the new-argocd-doc branch July 29, 2024 06:42
trdoyle81 pushed a commit to trdoyle81/gitops-operator that referenced this pull request Aug 13, 2024
…eloper#633)

* Update & reorganize new argocd creation doc

Signed-off-by: Siddhesh Ghadi <[email protected]>

* Update ArgoCD v1alpha1 ref to v1beta1

Signed-off-by: Siddhesh Ghadi <[email protected]>

---------

Signed-off-by: Siddhesh Ghadi <[email protected]>
Co-authored-by: Abhishek Veeramalla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants