Add ircPreventMention #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This adds a zero-width character to nicknames to prevent IRC-side pings.) Original commits: - Add ircPreventMention code - Document ircPreventMention - Make ircNickColor wrap the displayUsername - Fix build errors - Default ircPreventMention to false
Only tests turning it on; extant tests ensure it's off by default.
|
Cheers (although I don't use this project anymore!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #243. Original credit to @qaisjp, test added, README amended to state it's off by default. Single-character nicks get a random zero-width character appended, but it's not like that affects anything so meh.
Off by default, because some IRC clients were having trouble with it before. It's up to bot owners to make sure this doesn't break any functionality for their users (like maybe for languages where zero-width characters will mess up the language's script? on IRC servers supporting those characters in nicknames).
Fixes #197.