Skip to content

Conversation

doppins-bot
Copy link
Contributor

Hi!

A new version was just released of discord.js, so Doppins
has upgraded your project's dependency ranges.

Make sure that it doesn't break anything, and happy merging! :shipit:


Upgraded discord.js from 11.4.2 to 11.5.0

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage remained the same at 97.207% when pulling 8d18b65 on doppins/discord.js-equals-11.5.0 into d528aed on master.

@doppins-bot doppins-bot changed the title [Doppins] Upgrade dependency discord.js to 11.5.0 [Doppins] Upgrade dependency discord.js to 11.5.1 May 29, 2019
@doppins-bot
Copy link
Contributor Author

An additional new version was just released of discord.js, so we've added an
extra commit upgrading your range to 11.5.1.

Hope that's alright!
Doppins

@Throne3d
Copy link
Collaborator

@ekmartin What's the current policy on dependency upgrades? I've currently been leaving them to you, and it looks like you close any that update the major version, but I wanted to confirm this so I could help out with either merging them or rejecting them.

If that is the criterion, will we be doing major upgrades at some point? We don't currently need the newer features (that I know of), but we may miss out on some useful changes by staying on older major versions, so I wanted to know if there was a longer-term plan around them.

@Throne3d
Copy link
Collaborator

Throne3d commented Aug 8, 2019

Oh, looks like I just missed some of our individual dependency upgrades, because they were collated into different commits. I'll have a look through the rest of these.

@Throne3d Throne3d force-pushed the doppins/discord.js-equals-11.5.0 branch from 5661926 to 8d18b65 Compare August 8, 2019 15:32
@Throne3d
Copy link
Collaborator

Throne3d commented Aug 8, 2019

None of the deprecations appear to hit us, and it adds some fixes (though those probably also – mostly – won't affect us, just perhaps the Util.splitMessage one or WebhookClient's failed rate limiting): https://github.com/discordjs/discord.js/releases/tag/11.5.0, https://github.com/discordjs/discord.js/releases/tag/11.5.1. Looks fine to merge.

@Throne3d Throne3d merged commit c28151a into master Aug 8, 2019
@Throne3d Throne3d deleted the doppins/discord.js-equals-11.5.0 branch August 8, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants