Skip to content

Conversation

rdb
Copy link
Contributor

@rdb rdb commented Feb 11, 2019

On my IRC channel I've noticed people expect to be able to address Discord users like they usually do on IRC, in one of these two forms:

<ircuser1> discorduser: yes, I agree
<ircuser2> discorduser, I also agree with that

This PR makes it possible by extending the mention regex to transform a discorduser: or discorduser, at the beginning of a message into @discorduser.

@coveralls
Copy link

coveralls commented Feb 11, 2019

Coverage Status

Coverage increased (+0.009%) to 97.085% when pulling ba505ed on rdb:patch-1 into 3087661 on reactiflux:master.

Copy link
Member

@ekmartin ekmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. It would be helpful if you could try adding a test or two as well!

@rdb
Copy link
Contributor Author

rdb commented Mar 4, 2019

Added unit tests; looks like the checks passed.

@ekmartin ekmartin merged commit 5e3a8e2 into reactiflux:master Mar 5, 2019
@ekmartin
Copy link
Member

ekmartin commented Mar 5, 2019

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants