IRC Users joining/parting/quiting

[Ratismal]

I love Discord-IRC, but one of my major gripes with it is that IRC join/part/quit events aren't outputted to discord. I've just been manually changing my local files, but it's a bit irritating to do whenever I update. It would be great if this functionality came installed!

I have implemented this functionality in this branch. Feel free to change it as needed.

As a sidenote, I love the refactor that this code has received! It looks much cleaner.

[StrikerTheHedgefox]

Definitely this. Would be nice, in fact necessary if you want people to know if anyone is on the other side.

[polyzium]

Will this gonna be implemented or not??? This request's age is old af

[StrikerTheHedgefox]

Wondering the same.

[polyzium]

We need a review on that to make merging possible, i cannot do it because i ain't coder at all. at least i tried to merge by myself but i failed so i am waiting for someone to merge it

[polyzium]

let's see if that will work))) 52 upvotes and 0 downvotes definantly deserve the request to be merged... still i dont much know how github works. PLEASE DO IT GUYS

[StrikerTheHedgefox]

The code looks alright to me, it's simple enough at least. I'm not one of the devs however, so my approval doesn't mean shit.

[polyzium]

52 upvotes and 0 downvotes definantly deserve the request to be merged...

[RoyCurtis]

Merged this PR into our fork, thank you very much @Ratismal !

To get this PR working, I had to make a few changes to the code.

[polyzium]

@RoyCurtis Thanks i hope you will ressurect this project!

[RoyCurtis]

I don't think this project needs resurrecting, since the last commit was only 8 days ago. I also don't intend on taking over or providing support; that is purely just for our needs :)

[Ratismal]

Glad you got it working @RoyCurtis.

Considering how the last commit was to merge a 14 day old PR, and this PR was from over a year ago to implement basic events, I think there's little hope in the developers merging it.

I'd recommend any developers to manually integrate IRC support into their projects. If you're not a developer, you'll just have to make do.

The project certainly isn't "dead", it's not just actively developed.

[Throne3d]

Hm, is there a particular reason this PR hasn't been merged? (Maybe because it seems to lack tests?)

Edit: Is it the fact it's super old and rebasing it is horrible? :P

[Throne3d]

Well, I rebased this anyway (and updated bits of it to use the format of the new code), then added tests and extracted the bit that finds the discord channel, and overall hopefully it'll be readily mergeable. (See #207.)

[ekmartin]

Sorry that I haven't replied to this! The reason I didn't merge it originally was the lack of tests and the on by default behavior (needs to be behind a configuration option).

Let's try to get #207 merged. Thank you for your contribution @Ratismal.

[ekmartin]

Released in 2.3.0 - enable by setting ircStatusNotices to true in your config.