Test against Node 8, update package-lock.json #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node 8 has been out for a while, and should be supported as it seems likely a lot of the userbase will be using it. Test it in Travis to make sure there are no idiosyncracies between the versions.
Some dependencies have changed version, and the package-lock.json file hasn't been updated to reflect that. This rebuilds it to make it more in line with the package.json file.
Throne3d
changed the title
ekmartin
reviewed
Oct 22, 2017
.travis.yml
Outdated
| @@ -4,3 +4,4 @@ after_success: | |||
| node_js: | |||
| - '6' | |||
| - '7' | |||
There was a problem hiding this comment.
Let's remove v7? Since it's not an LTS release.
There was a problem hiding this comment.
That seems reasonable; done.
|
Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 8 has been out for a while, and should be supported as it seems likely a lot of the userbase will be using it. This PR adds it to the list of Node versions Travis tests, to make sure there are no idiosyncracies between the versions.
This PR also updates
package-lock.jsonper recent changes to thepackage.jsonfile. Travis looks like it might be stalling while having trouble runningnpm install(a problem parsing some JSON?) so this might fix that too.